Re: Test-cases for deferred constraints in plpgsql_transaction.sql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Test-cases for deferred constraints in plpgsql_transaction.sql
Date: 2018-07-02 13:37:43
Message-ID: 63505.1530538663@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> writes:
> On Mon, Jul 2, 2018 at 3:30 PM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> I won't say we don't need more tests, but I don't see a particular
>> testing gap in this area.

> I am not saying that the existing test-case is not enough to test
> deferred constraints but, it would have been good to add test-cases
> having ROLLBACK statements with deferred constraints as well.

What exactly would that test, other than that ROLLBACK discards changes?
Which is a point that seems to me to be pretty well covered already.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-07-02 13:41:05 Re: PANIC during crash recovery of a recently promoted standby
Previous Message Tom Lane 2018-07-02 13:26:30 Re: Should contrib modules install .h files?