| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | jj-zhang25(at)mails(dot)tsinghua(dot)edu(dot)cn, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #19644: byteaout, float8out and float4out are marked IMMUTABLE but depend on GUCs |
| Date: | 2026-10-19 12:45:56 |
| Message-ID: | 61ca987c-8bd1-4380-b81a-72c94c36b41c@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 08.09.26 10:34, Fujii Masao wrote:
> On Sat, Sep 5, 2026 at 2:27 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> It's been wrong for so long that I'm not that rushed to fix it in 19.
>> We might find that there are consequences to be dealt with, so better
>> to let the fix settle in master.
>
> Sounds reasonable.
>
>
>>> On further review, point_out, ISTM that lseg_out, path_out, box_out, poly_out,
>>> circle_out, and line_out are marked IMMUTABLE but depend on extra_float_digits.
>>> Similarly, pg_mcv_list_out is marked IMMUTABLE but depends on bytea_output.
>>> Perhaps we should fix these at the same time...
>>
>> Agreed.
>
> Attached patch marks those GUC-dependent type output functions as STABLE.
>
> In addition to the functions I mentioned upthread, I found that
> brin_minmax_multi_summary_out calls the summarized type's output
> function, so its result can depend on the GUCs. The patch marks that
> function STABLE as well.
cube_out() in contrib/cube/ should also be changed. Other than that,
this set looks correct to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jesper St John | 2026-10-19 14:33:14 | Timing issue in pg_basebackup |
| Previous Message | George MacKerron | 2026-10-19 11:34:41 | Re: Inconsistency in psql output with \d+x PATTERN |