Sehrope Sarkuni <sehrope(at)jackdb(dot)com> writes:
> One thing stood out, but it's from the existing code:
> - px_memset(&sha_buf_tmp, 0, sizeof sha_buf);
> + explicit_bzero(&sha_buf_tmp, sizeof sha_buf);
> That's sha_buf in the sizeof but we're zeroing out sha_buf_tmp.
+1 for fixing that. Also I think project style is to write sizeof
with parens.
regards, tom lane