| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Felix Lechner <felix(dot)lechner(at)lease-up(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Better cleanup in TLS tests for -13beta2 |
| Date: | 2020-06-29 19:02:44 |
| Message-ID: | 61506C79-F65C-45C4-AF2D-5756F9A9DCD1@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 29 Jun 2020, at 17:52, Felix Lechner <felix(dot)lechner(at)lease-up(dot)com> wrote:
> This patch removes two temporary files that are not removed. In
> Debian, repeated builds fail. We do not allow builds from modified
> sources.
Aha, nice catch!
> The first file was clearly an oversight. It was created separately. I
> am not sure why the loop over @keys did not remove the second.
That's because it's created in the 002_scram.pl testsuite as well, but not
cleaned up there.
The proposed patch admittedly seems a bit like a hack, and the client_tmo.key
handling is wrong as mentioned above. I propose that we instead add the key to
the @keys array and have clean up handle all files uniformly. The attached
fixes both of the files.
cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| tls_tests_cleanup.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-06-29 19:27:49 | Re: [PATCH] Better cleanup in TLS tests for -13beta2 |
| Previous Message | Tom Lane | 2020-06-29 18:58:57 | Re: pg_bsd_indent compiles bytecode |