Re: [PATCH] Better cleanup in TLS tests for -13beta2

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Felix Lechner <felix(dot)lechner(at)lease-up(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Better cleanup in TLS tests for -13beta2
Date: 2020-06-29 19:27:49
Message-ID: 366735.1593458869@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> The proposed patch admittedly seems a bit like a hack, and the client_tmo.key
> handling is wrong as mentioned above. I propose that we instead add the key to
> the @keys array and have clean up handle all files uniformly. The attached
> fixes both of the files.

Hmm ... so I guess my reaction to both of these is "what guarantees
that we get to the part of the script that does the unlinks?".
I've certainly seen lots of TAP tests fail to complete. Could we
do the cleanup in an END block or the like? (I'm a poor enough
Perl programmer to be uncertain what's the best way, but I know
Perl has constructs like that.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2020-06-29 19:37:54 Re: [PATCH] Better cleanup in TLS tests for -13beta2
Previous Message Daniel Gustafsson 2020-06-29 19:02:44 Re: [PATCH] Better cleanup in TLS tests for -13beta2