From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Process variadic arguments consistently in json functions |
Date: | 2017-10-26 12:18:56 |
Message-ID: | 614a2b95-1afd-66cc-1945-e178e2a58c82@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 10/26/2017 12:12 AM, Michael Paquier wrote:
> On Wed, Oct 25, 2017 at 5:24 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> Process variadic arguments consistently in json functions
>>
>> json_build_object and json_build_array and the jsonb equivalents did not
>> correctly process explicit VARIADIC arguments. They are modified to use
>> the new extract_variadic_args() utility function which abstracts away
>> the details of the call method.
>>
>> Michael Paquier, reviewed by Tom Lane and Dmitry Dolgov.
>>
>> Backpatch to 9.5 for the jsonb fixes and 9.4 for the json fixes, as
>> that's where they originated.
> - * Copyright (c) 2014-2017, PostgreSQL Global Development Group
> + * COPYRIGHT (c) 2014-2017, PostgreSQL Global Development Group
> Andrew, I have just noticed that this noise diff has crept in. You may
> want to fix that.
Argh! I see that in your v6 patch and I thought I'd caught all of it but
apparently not for master and REL_10. I wonder how that happened?
Will fix.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2017-10-26 12:23:12 | pgsql: Undo inadvertent change in capitalization in commit 18fc4ec. |
Previous Message | Robert Haas | 2017-10-26 10:42:21 | pgsql: In relevant log messages, indicate whether vacuums are aggressiv |
From | Date | Subject | |
---|---|---|---|
Next Message | Ashutosh Bapat | 2017-10-26 12:36:21 | Re: Transactions involving multiple postgres foreign servers |
Previous Message | Robert Haas | 2017-10-26 11:45:24 | Re: PATCH: pgbench - option to build using ppoll() for larger connection counts |