| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Wait event that should be reported while waiting for WAL archiving to finish |
| Date: | 2020-02-17 07:30:00 |
| Message-ID: | 61477660-dded-2550-b101-c76a2f864806@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/02/14 23:43, Robert Haas wrote:
> On Thu, Feb 13, 2020 at 10:47 PM Fujii Masao
> <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>> Fixed. Thanks for the review!
>
> I think it would be safer to just report the wait event during
> pg_usleep(1000000L) rather than putting those calls around the whole
> loop. It does not seem impossible that ereport() or
> CHECK_FOR_INTERRUPTS() could do something that reports a wait event
> internally.
OK, so I attached the updated version of the patch.
Thanks for the review!
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
| Attachment | Content-Type | Size |
|---|---|---|
| wait_event_wal_archive_v3.patch | text/plain | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2020-02-17 07:59:46 | Re: table partitioning and access privileges |
| Previous Message | Fujii Masao | 2020-02-17 07:24:12 | Re: Wait event that should be reported while waiting for WAL archiving to finish |