Re: Wait event that should be reported while waiting for WAL archiving to finish

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Wait event that should be reported while waiting for WAL archiving to finish
Date: 2020-02-14 14:43:11
Message-ID: CA+Tgmoa3BVNJ+LVrytUrsK+MtxEogc_jurDgJ=rkMAEt06Hk6Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 13, 2020 at 10:47 PM Fujii Masao
<masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> Fixed. Thanks for the review!

I think it would be safer to just report the wait event during
pg_usleep(1000000L) rather than putting those calls around the whole
loop. It does not seem impossible that ereport() or
CHECK_FOR_INTERRUPTS() could do something that reports a wait event
internally.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-02-14 14:52:10 Re: Fix compiler warnings on 64-bit Windows
Previous Message Tom Lane 2020-02-14 14:42:40 Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager