On 2018/12/17 17:25, Michael Paquier wrote:
> On Mon, Dec 17, 2018 at 04:41:01PM +0900, Amit Langote wrote:
>> Okay, let's use "Functions" then, although I wonder if you shouldn't tweak
>> it later when you commit the pg_partition_root patch?
>
> There are already two calls to pg_partition_tree for each one of the two
> relkinds tested.
You're saying that we should use plural "functions" because there of 2
*instances* of calling the function pg_partition_tree in the queries that
follow the comment, but I think that would be misleading. I think the
plural would make sense if we're talking about two different functions,
but I may be wrong.
Thanks,
Amit