Re: Fixing typos in tests of partition_info.sql

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fixing typos in tests of partition_info.sql
Date: 2018-12-17 09:10:08
Message-ID: 20181217091008.GG5223@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 17, 2018 at 05:56:08PM +0900, Amit Langote wrote:
> You're saying that we should use plural "functions" because there of 2
> *instances* of calling the function pg_partition_tree in the queries that
> follow the comment, but I think that would be misleading. I think the
> plural would make sense if we're talking about two different functions,
> but I may be wrong.

Or this could just use "Function calls"? My argument is just to not
forget about updating this comment later on and minimize future noise
diffs.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matsumura, Ryo 2018-12-17 09:11:10 RE: [PROPOSAL]a new data type 'bytea' for ECPG
Previous Message Amit Kapila 2018-12-17 09:09:50 Re: Remove double trailing semicolons