From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, tomas(at)tuxteam(dot)de, "Ragi Y(dot) Burhum" <rburhum(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: knngist patch support |
Date: | 2010-02-14 04:05:36 |
Message-ID: | 603c8f071002132005u4b259123m4a5e54603e0aebc3@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Feb 13, 2010 at 10:40 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> ...
>> 2. Modify pg_amop by adding a new column amopcategory, probably either
>> int2 or maybe even just char.
>> ...
>> I'm not prepared to endorse doing #3 in core for 9.0, but I wonder if
>> it would be feasible to think about doing #1 and #2 and putting
>> something into contrib for #3.
>
> No, we are not touching the system catalogs for this in 9.0, much less
> fooling with any planner logic. If it had been submitted a few months
> earlier that could have happened, but we are barely 48 hours away from
> alpha freeze. The only part of this that I think can even be considered
> at this point is to do a backwards-compatible source code upgrade that
> will decouple the various call sites from knowledge of exactly how many
> key columns the syscaches allow. And even that is not for the benefit
> of this feature; it's mainly to minimize breakage of other patches
> that will be developed between now and whenever knngist does land.
> (IOW, I agree with your point that making the call syntax change now
> is the least painful time to do that.)
OK. In that case, any objections to my applying the attached patch,
which I believe implements this as you suggested?
...Robert
Attachment | Content-Type | Size |
---|---|---|
syscache-macros-v1.patch | application/octet-stream | 269.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-02-14 04:34:51 | CommitFest Status Summary - 2010-02-14 |
Previous Message | Tom Lane | 2010-02-14 03:40:23 | Re: knngist patch support |