From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Sam Mason <sam(at)samason(dot)me(dot)uk>, pgsql-general(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] libpq port number handling |
Date: | 2009-09-25 01:31:42 |
Message-ID: | 603c8f070909241831i13711e37w20af024584eb4eab@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
On Thu, Sep 24, 2009 at 8:59 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Sam Mason <sam(at)samason(dot)me(dot)uk> writes:
>> + if (portnum < 1 || portnum > 65535)
>
> BTW, it strikes me that we could tighten this even more by rejecting
> target ports below 1024. This is guaranteed safe on all Unix systems
> I know of, because privileged ports can only be listened to by root-owned
> processes and we know the postmaster won't be one. I am not sure
> whether it would be possible to start the postmaster on a low-numbered
> port on Windows though. Anyone know? Even if it's possible, do we
> want to allow it?
I don't think we get much benefit out of artificially limiting libpq
in this way. In 99.99% of cases it won't matter, and in the other
0.01% it will be a needless annoyance. I think we should restrict
ourselves to checking what is legal, not what we think is a good idea.
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Selena Deckelmann | 2009-09-25 02:50:30 | Re: Looking for way to replicate master db to multiple mobile databases |
Previous Message | Kris Jurka | 2009-09-25 01:27:42 | Re: [HACKERS] libpq port number handling |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2009-09-25 02:33:43 | Re: syslog_line_prefix |
Previous Message | Kris Jurka | 2009-09-25 01:27:42 | Re: [HACKERS] libpq port number handling |