Re: Unexpected behavior when setting "idle_replication_slot_timeout"

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Gunnar Morling <gunnar(dot)morling(at)googlemail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: Unexpected behavior when setting "idle_replication_slot_timeout"
Date: 2025-07-10 10:27:08
Message-ID: 5fddbcc5-0c05-493d-a3f0-1fe49ffe5600@oss.nttdata.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2025/07/10 14:51, Laurenz Albe wrote:
> On Thu, 2025-07-10 at 05:27 +0000, Hayato Kuroda (Fujitsu) wrote:
>>>> The "hybrid approach" saves the two seconds on system with injection points,
>>>> but cannot simplify the code.
>>>
>>> I feel that would be a needless complexity in the test.
>>
>> Yeah, it is the down side of the approach. If it do not have enough advantage, let's drop the idea.
>
> Great, then I think that we have consensus.
> Let's change to seconds and leave the injectsion points and tests as they are.

+1

> I'd still like to see the documentation improved, like my patch tried to do.

Agreed.

I created this as a separate patch from the one that changes the unit,
since they serve different purposes. Both patches are attached.
I'm planning to commit them.

Regards,

--
Fujii Masao
NTT DATA Japan Corporation

Attachment Content-Type Size
v3-0001-Change-unit-of-idle_replication_slot_timeout-to-s.patch text/plain 6.9 KB
v3-0002-doc-Clarify-meaning-of-idle-in-idle_replication_s.patch text/plain 3.4 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Aleksander Alekseev 2025-07-10 10:59:23 Re: PostgreSQL 18 beta1 - Segmentation fault on custom type casting
Previous Message Jim Jones 2025-07-10 09:13:31 Re: Starting a PostgreSQL server on a dynamic port (parameter port=0)