| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: check_recovery_target_lsn() does a PG_CATCH without a throw |
| Date: | 2019-06-20 13:42:14 |
| Message-ID: | 5da47275-9737-77e4-e7ac-26bcd61d1374@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-06-12 13:16, Peter Eisentraut wrote:
> I haven't figured out the time zone issue yet, but I guess the solution
> might involve moving some of the code from check_recovery_target_time()
> to assign_recovery_target_time().
I think that won't work either. What we need to do is postpone the
interpretation of the timestamp string until after all the GUC
processing is done. So check_recovery_target_time() would just do some
basic parsing checks, but stores the string. Then when we need the
recovery_target_time_value we do the final parsing. Then we can be sure
that the time zone is all set.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2019-06-20 13:46:52 | Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS) |
| Previous Message | Thomas Munro | 2019-06-20 13:21:09 | old_snapshot_threshold vs indexes |