| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: check_recovery_target_lsn() does a PG_CATCH without a throw |
| Date: | 2019-06-12 11:16:54 |
| Message-ID: | 478c8dfc-0c64-c2c3-1e3f-6dd688354e1d@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-06-11 08:11, Andres Freund wrote:
> While working on fixing [1] I noticed that 2dedf4d9a899 "Integrate
> recovery.conf into postgresql.conf" added two non-rethrowing PG_CATCH
> uses. That's not OK.
Right. Here is a patch that addresses this by copying the relevant code
from pg_lsn_in() and timestamptz_in() directly into the check hooks.
It's obviously a bit unfortunate not to be able to share that code, but
it's not actually that much.
I haven't figured out the time zone issue yet, but I guess the solution
might involve moving some of the code from check_recovery_target_time()
to assign_recovery_target_time().
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-explicit-error-handling-for-obsolete-date-tim.patch | text/plain | 14.6 KB |
| 0002-Don-t-call-data-type-input-functions-in-GUC-check-ho.patch | text/plain | 5.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2019-06-12 11:36:08 | Re: Adaptive query optimization |
| Previous Message | Siarhei Siniak | 2019-06-12 10:11:05 | Re: GiST limits on contrib/cube with dimension > 100? |