Re: [PATCH] Add XMLText function (SQL/XML X038)

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: Vik Fearing <vik(at)postgresfriends(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add XMLText function (SQL/XML X038)
Date: 2023-11-03 15:30:17
Message-ID: 5F665F1B-4FE4-48C3-90D7-3F0088FB358F@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 25 Aug 2023, at 17:40, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> wrote:
> On 25.08.23 16:49, Vik Fearing wrote:

>> I do not think this should be addressed in this patch because there are quite a lot of functions that need to handle this.
>
> v4 attached.

I had a look at v4 of this patch and apart from pgindenting and moving the
function within xml.c next to xmlcomment() I think this is ready.

Just like Vik says upthread we can't really claim X038 conformance without a
disclaimer, so I've added a 0002 which adds this to the XML spec conformance
page in the docs.

The attached v5 contains the above mentioned changes. I've marked this ready
for committer in the CF app as well.

--
Daniel Gustafsson

Attachment Content-Type Size
v5-0001-Add-XMLText-function-SQL-XML-X038.patch application/octet-stream 8.5 KB
v5-0002-doc-Add-a-note-about-not-supporting-XML-SEQUENCE.patch application/octet-stream 1.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Hills 2023-11-03 15:43:43 Re: Regression on pg_restore to 16.0: DOMAIN not available to SQL function
Previous Message Nikita Malakhov 2023-11-03 15:20:03 Re: remaining sql/json patches