Re: Different compression methods for FPI

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Different compression methods for FPI
Date: 2021-06-20 18:15:08
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> 17 июня 2021 г., в 11:44, Michael Paquier <michael(at)paquier(dot)xyz> написал(а):
> I have worked more on that today and finished with two patches

I have some small questions.

+ report_invalid_record(record, "image at %X/%X compressed with %s not supported, block %d",
+ (uint32) (record->ReadRecPtr >> 32),
+ (uint32) record->ReadRecPtr,
+ "lz4",
+ block_id);
Can we point out to user that the problem is in the build? Also, maybe %s can be inlined to lz4 in this case.

> const char *method = "???";
Maybe we can use something like "unknown" for unknown compression methods? Or is it too long string for waldump output?

3. Can we exclude lz4 from config if it's not supported by the build?


Best regards, Andrey Borodin.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-06-20 18:37:09 Re: Race condition in InvalidateObsoleteReplicationSlots()
Previous Message Andrew Dunstan 2021-06-20 17:24:04 Re: PXGS vs TAP tests