Re: [HACKERS] Useless code in ExecInitModifyTable

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Useless code in ExecInitModifyTable
Date: 2018-01-15 08:10:09
Message-ID: 5A5C61E1.2020600@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

(2018/01/15 11:35), Amit Langote wrote:
> On 2018/01/15 11:28, Stephen Frost wrote:
>> Seems like this has gotten a review (and quite a bit of down-stream
>> discussion that seemed pretty positive), and the latest patch still
>> applies cleanly and passes the regression tests- is there some reason
>> it's still marked as Needs Review? Seems like it should really be in
>> Ready for Committer state.

Thanks for taking care of this, Stephen!

> +1.
>
>> Amit, if you agree, would you mind going ahead and changing it?
>
> Sure, done.

Thanks for reviewing, Amit!

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2018-01-15 09:11:16 Re: Removing WITH clause support in CREATE FUNCTION, for isCachable and isStrict
Previous Message Etsuro Fujita 2018-01-15 08:09:19 Re: [HACKERS] postgres_fdw bug in 9.6