| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Useless code in ExecInitModifyTable |
| Date: | 2018-01-17 19:46:00 |
| Message-ID: | 2243.1516218360@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> (2018/01/15 11:35), Amit Langote wrote:
>> On 2018/01/15 11:28, Stephen Frost wrote:
>>> Seems like this has gotten a review (and quite a bit of down-stream
>>> discussion that seemed pretty positive), and the latest patch still
>>> applies cleanly and passes the regression tests- is there some reason
>>> it's still marked as Needs Review? Seems like it should really be in
>>> Ready for Committer state.
>>> Amit, if you agree, would you mind going ahead and changing it?
>> Sure, done.
> Thanks for reviewing, Amit!
Pushed. I think the long delay on this is really my fault for having
raised an incorrect objection initially --- apologies for that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Claudio Freire | 2018-01-17 19:51:43 | Re: [HACKERS] [PATCH] Vacuum: Update FSM more frequently |
| Previous Message | Robert Haas | 2018-01-17 19:29:05 | Re: [HACKERS] PATCH: enabling parallel execution for cursors explicitly (experimental) |