Incorrect comment for expand_single_inheritance_child

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Incorrect comment for expand_single_inheritance_child
Date: 2018-01-09 03:37:08
Message-ID: 5A5438E4.3090709@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here is part of comments for expand_single_inheritance_child:

* expand_single_inheritance_child
* Expand a single inheritance child, if needed.
*
* If this is a temp table of another backend, we'll return without doing
* anything at all. Otherwise, build a RangeTblEntry and an
AppendRelInfo, if
* appropriate, plus maybe a PlanRowMark.

The sentence "If this is a temp table of another backend, we'll return
without doing anything at all" is not correct, because that function
doesn't even check whether the given child is such a temp table. (The
caller does, so that function assumes that the given child is not such a
temp table.) So I think we should remove that sentence entirely. Also,
I think we should remove "if needed" from the headline: Expand a single
inheritance child, if needed. IMO I don't think that "Expand a single
inheritance child" says much, so I'd like to propose changing that part
simply to something like this:

* expand_single_inheritance_child
* Build a RangeTblEntry and an AppendRelInfo, if appropriate, plus
* maybe a PlanRowMark.

Attached is a patch for that.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
prepunion-comment-fix.patch text/x-diff 962 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2018-01-09 03:48:10 Re: Invalid pg_upgrade error message during live check
Previous Message Michael Paquier 2018-01-09 03:34:19 Use of term hostaddrs for multiple hostaddr values