Re: [HACKERS] Add support for tuple routing to foreign partitions

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Maksim Milyutin <milyutinma(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: [HACKERS] Add support for tuple routing to foreign partitions
Date: 2017-12-19 12:05:55
Message-ID: 5A3900A3.3010404@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

(2017/12/18 23:25), Alvaro Herrera wrote:
> InitResultRelInfo becomes unintelligible after this patch -- it was
> straightforward but adding partition_root makes things shaky. Please
> add a proper comment indicating what each argument is.

I was thiking that the comment I added to the definition of the
ResultRelInfo struct in execnodes.h would make that function
intelligible, but I agree on that point. Please fined attached a new
version of the patch adding such comments.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
tuple-routing-to-foreign-partitions-v7.patch text/x-diff 62.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2017-12-19 12:52:31 Re: Tracking of page changes for backup purposes. PTRACK [POC]
Previous Message Amit Kapila 2017-12-19 12:02:32 Re: Top-N sorts verses parallelism