Re: [HACKERS] Add support for tuple routing to foreign partitions

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Maksim Milyutin <milyutinma(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: [HACKERS] Add support for tuple routing to foreign partitions
Date: 2018-01-25 14:33:38
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


* Etsuro Fujita (fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp) wrote:
> (2017/12/18 23:25), Alvaro Herrera wrote:
> >InitResultRelInfo becomes unintelligible after this patch -- it was
> >straightforward but adding partition_root makes things shaky. Please
> >add a proper comment indicating what each argument is.
> I was thiking that the comment I added to the definition of the
> ResultRelInfo struct in execnodes.h would make that function intelligible,
> but I agree on that point. Please fined attached a new version of the patch
> adding such comments.

I'm afraid a good bit of this patch is now failing to apply. I don't
have much else to say except to echo the performance concern that Amit
Langote raised about expanding the inheritence tree twice.



In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-01-25 14:35:26 Re: Foreign keys and partitioned tables
Previous Message Alexander Korotkov 2018-01-25 14:32:45 Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index