Re: [PG19]pg_verifybackup never finishes on a gzip-compressed tar backup

On 2026-10-07 We 8:48 PM, Chao Li wrote:
>
>> On Oct 7, 2026, at 19:44, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> On 6 Oct 2026, at 03:48, shihao zhong <zhong950419(at)gmail(dot)com> wrote:
>>> I took a look at the code and I think we are solving different problems.
>> I concur that this is a separate issue. Today I returned to looking at the
>> truncation patchset and I am including this fix in that review effort.
>>
>> --
>> Daniel Gustafsson
>>
> Sorry for the confusion. I was on vacation and didn’t look into the patch closely.
>
> This seems to be an old bug that couldn’t be triggered before PG19 (b15c1513984 added tar support to pg_waldump). So, I agree with Melanie that this should be an 19 open item.
>
> The patch calls inflateReset() after each member finishes, allowing decompression to continue with the next member, which looks like a correct fix to me.
>

Yes, looks good to me. I will commit later today.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com