| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | shihao zhong <zhong950419(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, sulamul(at)gmail(dot)com, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: [PG19]pg_verifybackup never finishes on a gzip-compressed tar backup |
| Date: | 2026-10-08 00:48:21 |
| Message-ID: | 961B3DEF-1F9E-400E-AA4D-D11AF6F016F9@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Oct 7, 2026, at 19:44, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 6 Oct 2026, at 03:48, shihao zhong <zhong950419(at)gmail(dot)com> wrote:
>
>> I took a look at the code and I think we are solving different problems.
>
> I concur that this is a separate issue. Today I returned to looking at the
> truncation patchset and I am including this fix in that review effort.
>
> --
> Daniel Gustafsson
>
Sorry for the confusion. I was on vacation and didn’t look into the patch closely.
This seems to be an old bug that couldn’t be triggered before PG19 (b15c1513984 added tar support to pg_waldump). So, I agree with Melanie that this should be an 19 open item.
The patch calls inflateReset() after each member finishes, allowing decompression to continue with the next member, which looks like a correct fix to me.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2026-10-08 01:05:54 | Wrong results from a parameterized Append |
| Previous Message | Fujii Masao | 2026-10-08 00:33:43 | Re: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation |