|From:||Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp>|
|To:||Michael Paquier <michael(dot)paquier(at)gmail(dot)com>|
|Cc:||PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: CLUSTER command progress monitor|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2017/09/04 15:38, Michael Paquier wrote:
> On Thu, Aug 31, 2017 at 11:12 AM, Tatsuro Yamada
> <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> Then I have questions.
>> * Should we have separate views for them? Or should both be covered by the
>> same view with some indication of which command (CLUSTER or VACUUM FULL)
>> is actually running?
> Using the same view for both, and tell that this is rather VACUUM or
> CLUSTER in the view, would be better IMO. Coming up with a name more
> generic than pg_stat_progress_cluster may be better though if this
> speaks with VACUUM FULL as well, user-facing documentation does not
> say that VACUUM FULL is actually CLUSTER.
Thanks for sharing your thoughts.
I'll add new column like a "command" to tell whether running CLUSTER or VACUUM.
And how about this new view name?
Is it more general name than previous name if it covers both commands?
>> I'll add this patch to CF2017-09.
>> Any comments or suggestion are welcome.
> Nice to see that you are taking the time to implement patches for
> upstream, Yamada-san!
Same here. :)
I'd like to contribute creating feature that is for DBA and users.
Progress monitoring feature is important from my DBA experiences.
I'm happy if you lend your hand.
|Next Message||Sokolov Yura||2017-09-04 11:20:52||Re: Walsender timeouts and large transactions|
|Previous Message||Magnus Hagander||2017-09-04 11:14:10||Re: Release Note changes|