Re: Reject HEADER with binary and json COPY formats by option presence

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Reject HEADER with binary and json COPY formats by option presence
Date: 2026-06-29 03:23:44
Message-ID: 58239424-7C23-4E11-9EB4-B03651253E0E@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Jun 3, 2026, at 14:55, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Wed, Jun 3, 2026 at 2:24 PM Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
>>
>> On Sun, May 31, 2026 at 10:57 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>>
>>> While testing “file_fdw: Support multi-line HEADER option”, I noticed a small issue.
>>
>> Thanks for reporting this!
>
> I'm not yet convinced that this needs a code change. We already seem to have
> both styles today: some options are rejected based on their presence,
> while others are effectively judged based on whether the specified value
> actually enables the feature. I don't think we have a clear rule that
> everything should be presence-based.
>
> Regards,
>
> --
> Fujii Masao

Okay, I withdraw this patch.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Chao Li 2026-06-29 03:21:46 Re: COPY: validate option presence rather than option values