Re: Reject HEADER with binary and json COPY formats by option presence

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Reject HEADER with binary and json COPY formats by option presence
Date: 2026-06-03 06:55:02
Message-ID: CAHGQGwEU7507_wFSkzHdHrmK5nnuWremdRgAzEkk0ft1kUrHbw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 3, 2026 at 2:24 PM Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
>
> On Sun, May 31, 2026 at 10:57 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> > While testing “file_fdw: Support multi-line HEADER option”, I noticed a small issue.
>
> Thanks for reporting this!

I'm not yet convinced that this needs a code change. We already seem to have
both styles today: some options are rejected based on their presence,
while others are effectively judged based on whether the specified value
actually enables the feature. I don't think we have a clear rule that
everything should be presence-based.

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2026-06-03 06:58:45 Re: Fix bug of CHECK constraint enforceability recursion
Previous Message Maksim.Melnikov 2026-06-03 06:33:41 Re: Init connection time grows quadratically