| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Add function to import operating system collations |
| Date: | 2017-01-18 18:52:31 |
| Message-ID: | 57d99bf7-abaa-16bb-7ea8-1ca019c4caf6@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 1/18/17 1:46 PM, Tom Lane wrote:
> I wrote:
>> The previous coding applied a sort so as not to depend on what
>> order "locale -a" had returned things in, and I think we need
>> to retain that. At the very least, all the normalized names
>> need to be saved up and entered in a second pass.
>
> Actually, it seems like doing precisely that should be enough to fix
> it. The original names shouldn't have any dups, and if we generate
> dup names by stripping, those will be for different encodings so it's
> OK. I've pushed a fix based on that.
Yeah, I was just about to write the exact same code. Looks good, thanks.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-01-18 18:56:26 | pgsql: Factor out logic for computing number of parallel workers. |
| Previous Message | Tom Lane | 2017-01-18 18:46:03 | Re: pgsql: Add function to import operating system collations |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-01-18 18:56:35 | Re: Parallel bitmap heap scan |
| Previous Message | Tom Lane | 2017-01-18 18:46:03 | Re: pgsql: Add function to import operating system collations |