| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Add function to import operating system collations |
| Date: | 2017-01-18 18:46:03 |
| Message-ID: | 2820.1484765163@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
I wrote:
> The previous coding applied a sort so as not to depend on what
> order "locale -a" had returned things in, and I think we need
> to retain that. At the very least, all the normalized names
> need to be saved up and entered in a second pass.
Actually, it seems like doing precisely that should be enough to fix
it. The original names shouldn't have any dups, and if we generate
dup names by stripping, those will be for different encodings so it's
OK. I've pushed a fix based on that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-01-18 18:52:31 | Re: pgsql: Add function to import operating system collations |
| Previous Message | Tom Lane | 2017-01-18 18:44:25 | pgsql: Avoid conflicts with collation aliases generated by stripping. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-01-18 18:52:31 | Re: pgsql: Add function to import operating system collations |
| Previous Message | Robert Haas | 2017-01-18 18:32:21 | Re: PoC: Grouped base relation |