| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_rewind copies |
| Date: | 2022-04-01 11:46:19 |
| Message-ID: | 57D49E3F-38DB-42B4-A76F-9A6B99F16958@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 1 Apr 2022, at 12:46, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>> + if (len >= sizeof(dstpath))
>> + pg_fatal("filepath buffer too small"); /* shouldn't happen */
>
> Makes sense. I would remove the "shouldn't happen"; it's not very hard to make it happen, you just need a very long target datadir path. And rephrase the error message as "datadir path too long".
Right, good point.
> One typo in the commit message: s/update/updates/.
Will fix.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-04-01 11:53:10 | Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set |
| Previous Message | Heikki Linnakangas | 2022-04-01 10:46:01 | Re: pg_rewind copies |