Re: split TOAST support out of postgres.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: split TOAST support out of postgres.h
Date: 2022-12-29 17:47:29
Message-ID: 579624.1672336049@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> writes:
> On Thu, 29 Dec 2022 at 18:16, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> We have a bunch of toast*.h files already. The new header should pretty much
>> only contain the types, given how widely the header is going to be
>> included. So maybe toast_type.h?

> My 2 cents: I don't think that toast_anything.h is appropriate,
> because even though the varatt infrastructure does enable
> externally-stored oversized attributes (which is the essence of
> TOAST), this is not the only (or primary) use of the type.

+1 ... varatt.h sounded fine to me. I'd suggest varlena.h except
we have one already.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2022-12-29 18:26:57 Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and possible memory issue)
Previous Message Peter Geoghegan 2022-12-29 17:43:39 Re: Avoiding unnecessary clog lookups while freezing