| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, David Zuelke <dz(at)heroku(dot)com> |
| Subject: | Re: Fix for OpenSSL error queue bug |
| Date: | 2016-04-08 01:23:27 |
| Message-ID: | 5707080F.2030705@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/07/2016 03:47 AM, Michael Paquier wrote:
> I have looked at this patch. Do we need to worry as well about
> SSL_shutdown in disconnection code path? I believe that we don't care
> much if an error happens at this point but we surely should consume
> any error generated because the SSL context is kept after
> destroy_ssl_system and another connection attempt may be done using
> the same SSL context, no?
But we are the only user of our SSL context, and we clear the error
before every call we make (with this patch). The clean up afterwards is
only if someone else is also using SSL in the same process, and they
won't use our SSL context.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2016-04-08 01:36:16 | Re: Fix for OpenSSL error queue bug |
| Previous Message | Michael Paquier | 2016-04-08 01:14:15 | Re: VS 2015 support in src/tools/msvc |