Re: s/pg_attribute_always_inline/pg_always_inline/?

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: s/pg_attribute_always_inline/pg_always_inline/?
Date: 2026-04-09 00:00:37
Message-ID: 56def459-2b95-42bc-b4e4-26e57f08b064@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08.04.26 23:09, Andres Freund wrote:
> Hi,
>
> When reviewing the index prefetching patch I got a bit dismayed at how long
> pg_attribute_always_inline is due to the way it triggers pgindent to format
> stuff.
>
> I propose that we remove the _attribute_ part of the name.
>
> Given that it is implemented for compilers that don't use the
> __attribute__((always_inline)) spelling, so the shorter name seems better
> anyway.

Yes, and the existing name is also kind of wrong even on GCC because the
macro does not expand to only an attribute but also includes the "inline".

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-04-09 00:20:00 Re: pgstat vs aset
Previous Message Michael Paquier 2026-04-08 23:54:49 Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier