| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Subject: | Re: Proposal: Generic WAL logical messages |
| Date: | 2016-03-16 15:56:44 |
| Message-ID: | 56E9823C.5060805@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/9/16 6:58 PM, Petr Jelinek wrote:
> On 08/03/16 21:21, Artur Zakirov wrote:
>> I think here
>>
>>> +const char *
>>> +logicalmsg_identify(uint8 info)
>>> +{
>>> + if (info & ~XLR_INFO_MASK == XLOG_LOGICAL_MESSAGE)
>>> + return "MESSAGE";
>>> +
>>> + return NULL;
>>> +}
>>
>> we should use brackets
>>
>> const char *
>> logicalmsg_identify(uint8 info)
>> {
>> if ((info & ~XLR_INFO_MASK) == XLOG_LOGICAL_MESSAGE)
>> return "MESSAGE";
>>
>> return NULL;
>> }
>>
>
> Correct, fixed, thanks.
>
> I also rebased this as there was conflict after the fixes to logical
> decoding by Andres.
This patch applies cleanly and is ready for review with no outstanding
issues that I can see. Simon and Artur, you are both signed up as
reviewers. Care to take a crack at it?
Thanks,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-03-16 15:57:25 | Re: pgbench - allow backslash-continuations in custom scripts |
| Previous Message | Pavel Stehule | 2016-03-16 15:50:56 | Re: plpgsql - DECLARE - cannot to use %TYPE or %ROWTYPE for composite types |