| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fuzzy substring searching with the pg_trgm extension |
| Date: | 2016-03-15 14:28:29 |
| Message-ID: | 56E81C0D.9060106@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/14/16 12:27 PM, Artur Zakirov wrote:
> On 14.03.2016 18:48, David Steele wrote:
>> Hi Jeff,
>>
>> On 2/25/16 5:00 PM, Jeff Janes wrote:
>>
>>> But, It doesn't sound like I am going to win that debate. Given that,
>>> I don't think we need a different name for the function. I'm fine with
>>> explaining the word-boundary subtlety in the documentation, and
>>> keeping the function name itself simple.
>>
>> It's not clear to me if you are requesting more documentation here or
>> stating that you are happy with it as-is. Care to elaborate?
>>
>> Other than that I think this patch looks to be ready for committer. Any
>> objections?
>>
>
> There was some comments about the word-boundary subtlety. But I think it
> was not enough.
>
> I rephrased the explanation of word_similarity() and %>. It is better now.
>
> But if it is not correct I can change the explanation.
Since to only change in the latest patch is to documentation I have
marked this "ready for committer".
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-03-15 14:39:50 | Re: silent data loss with ext4 / all current versions |
| Previous Message | Amit Kapila | 2016-03-15 14:25:49 | Re: Speed up Clog Access by increasing CLOG buffers |