| From: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: auto_explain sample rate |
| Date: | 2016-03-10 19:59:28 |
| Message-ID: | 56E1D220.2050106@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/03/2016 04:37, Petr Jelinek wrote:
> On 17/02/16 01:17, Julien Rouhaud wrote:
>>
>> Agreed, it's too obscure. Attached v4 fixes as you said.
>>
>
> Seems to be simple enough patch and works. However I would like
> documentation to say that the range is 0 to 1 and represents fraction of
> the queries sampled, because right now both the GUC description and the
> documentation say it's in percent but that's not really true as percent
> is 0 to 100.
>
Agreed. v5 attached fixes that.
--
Julien Rouhaud
http://dalibo.com - http://dalibo.org
| Attachment | Content-Type | Size |
|---|---|---|
| auto_explain_sample_rate-v5.diff | text/x-patch | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-03-10 20:03:41 | Re: WIP: Upper planner pathification |
| Previous Message | Peter Geoghegan | 2016-03-10 19:51:59 | Re: WIP: Upper planner pathification |