| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: auto_explain sample rate |
| Date: | 2016-03-10 21:07:55 |
| Message-ID: | 56E1E22B.1030808@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/03/16 20:59, Julien Rouhaud wrote:
> On 10/03/2016 04:37, Petr Jelinek wrote:
>> On 17/02/16 01:17, Julien Rouhaud wrote:
>>>
>>> Agreed, it's too obscure. Attached v4 fixes as you said.
>>>
>>
>> Seems to be simple enough patch and works. However I would like
>> documentation to say that the range is 0 to 1 and represents fraction of
>> the queries sampled, because right now both the GUC description and the
>> documentation say it's in percent but that's not really true as percent
>> is 0 to 100.
>>
>
> Agreed. v5 attached fixes that.
>
Great, I will test it once more (just because when I don't bugs suddenly
appear out of nowhere) and mark it ready for committer.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-03-10 21:16:38 | Re: Freeze avoidance of very large table. |
| Previous Message | Simon Riggs | 2016-03-10 21:00:31 | Re: WIP: Detecting SSI conflicts before reporting constraint violations |