| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Equivalent of --enable-tap-tests in MSVC scripts |
| Date: | 2016-03-01 15:40:12 |
| Message-ID: | 56D5B7DC.6070403@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/01/2016 08:00 AM, Michael Paquier wrote:
> Hi all,
>
> As of now the MSVC scripts control if TAP tests are enabled or not
> using a boolean flag as $config->{tap_tests}. However, this flag is
> just taken into account in vcregress.pl, with the following issues:
> 1) config_default.pl does not list tap_tests, so it is unclear to
> users to enable them. People need to look into vcregress.pl as a start
> point.
> 2) GetFakeConfigure() does not translate $config->{tap_tests} into
> --enable-tap-tests, leading to pg_config not reporting it in
> CONFIGURE. This is inconsistent with what is done in ./configure.
>
> Attached is a patch to address those two issues.
>
Good work. There seem to be some unrelated whitespace changes. Shouldn't
this just be two extra lines?
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-03-01 15:40:47 | Re: [NOVICE] WHERE clause not used when index is used |
| Previous Message | Bruce Momjian | 2016-03-01 15:37:42 | Re: The plan for FDW-based sharding |