| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Proposal: "Causal reads" mode for load balancing reads without stale data |
| Date: | 2016-02-03 09:59:56 |
| Message-ID: | 56B1CF9C.9070507@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Thomas,
On 2016/01/20 13:12, Thomas Munro wrote:
> That one conflicts with b1a9bad9e744857291c7d5516080527da8219854, so
> here is a new version.
- if (walsndctl->lsn[SYNC_REP_WAIT_WRITE] < MyWalSnd->write)
+ if (is_highest_priority_sync_standby)
[ ... ]
- if (walsndctl->lsn[SYNC_REP_WAIT_FLUSH] < MyWalSnd->flush)
- {
- walsndctl->lsn[SYNC_REP_WAIT_FLUSH] = MyWalSnd->flush;
- numflush = SyncRepWakeQueue(false, SYNC_REP_WAIT_FLUSH);
[ ... ]
+ if (walsndctl->lsn[SYNC_REP_WAIT_FLUSH] < MyWalSnd->write)
+ {
+ walsndctl->lsn[SYNC_REP_WAIT_FLUSH] = MyWalSnd->flush;
+ numflush = SyncRepWakeQueue(false, SYNC_REP_WAIT_FLUSH,
+ MyWalSnd->flush);
There seems to be a copy-pasto there - shouldn't that be:
+ if (walsndctl->lsn[SYNC_REP_WAIT_FLUSH] < MyWalSnd->flush)
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2016-02-03 10:01:06 | Re: Optimization for updating foreign tables in Postgres FDW |
| Previous Message | Peter Moser | 2016-02-03 09:38:34 | Development with Eclipse - Wrong error messages in IDE |