Re: [COMMITTERS] pgsql: Blind attempt at a Cygwin fix

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Marco Atzeri <marco(dot)atzeri(at)gmail(dot)com>
Subject: Re: [COMMITTERS] pgsql: Blind attempt at a Cygwin fix
Date: 2016-01-09 17:00:58
Message-ID: 56913CCA.4080509@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 01/08/2016 11:17 AM, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> Alvaro Herrera wrote:
>>> Obviously this wasn't the best idea ever. Andrew suggests on IM to
>>> revert this on Cygwin to just do the "isatty" check as originally.
>> Here's a proposed patch. Thoughts?
> Ugly, but it will hold the fort until someone can debug the service
> code for Cygwin.
>
>

I downloaded the official Cygwin packages into a Cygwin instance and
checked how they do things. As I rather expected, they do not use pg_ctl
at all to install or run as a service. Rather, they use the standard
Cygwin service utility cygrunsrv. This is all managed via a SYSV style
init script.

So if anything I'd be inclined to disable all the service-related code
in pg_ctl for Cygwin, and treat it just as we treat Unix.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2016-01-09 17:58:01 Re: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM
Previous Message Andres Freund 2016-01-09 12:23:55 Re: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM

Browse pgsql-hackers by date

  From Date Subject
Next Message Artur Zakirov 2016-01-09 17:31:59 Re: [PROPOSAL] Improvements of Hunspell dictionaries support
Previous Message Fabien COELHO 2016-01-09 15:49:56 Re: checkpointer continuous flushing