Re: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM

From: Andres Freund <andres(at)anarazel(dot)de>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM
Date: 2016-01-09 12:23:55
Message-ID: 20160109122355.ydzn4n5wwhe7objs@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2016-01-09 10:13:27 +0000, Simon Riggs wrote:
> src/backend/access/rmgrdesc/nbtdesc.c | 2 +-

I've not reviewed the patch, but a very quick glance during a rebase
with conflicts showed:

@@ -48,7 +48,7 @@ btree_desc(StringInfo buf, XLogReaderState *record)
{
xl_btree_vacuum *xlrec = (xl_btree_vacuum *) rec;

- appendStringInfo(buf, "lastBlockVacuumed %u",
+ appendStringInfo(buf, "lastBlockVacuumed %d",
xlrec->lastBlockVacuumed);
break;
}

which doesn't look right?

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2016-01-09 17:00:58 Re: [COMMITTERS] pgsql: Blind attempt at a Cygwin fix
Previous Message Simon Riggs 2016-01-09 10:13:27 pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM

Browse pgsql-hackers by date

  From Date Subject
Next Message Stas Kelvich 2016-01-09 12:26:27 Re: Speedup twophase transactions
Previous Message Simon Riggs 2016-01-09 10:13:27 pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM