|From:||Teodor Sigaev <teodor(at)sigaev(dot)ru>|
|To:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|Subject:||Re: pgsql: Allow to omit boundaries in array subscript|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
I will work on it.
Tom Lane wrote:
> Teodor Sigaev <teodor(at)sigaev(dot)ru> writes:
>> Allow to omit boundaries in array subscript
> For the record, this patch wasn't nearly ready to commit.
> * User-facing documentation is very poor; at the least it needs
> copy-editing by someone with better command of English.
> * Comments are next to nonexistent. I note for example that the
> description of struct A_Indices wasn't updated, much less that of
> * Some error messages aren't meeting the style guidelines.
> * I'm dubious that the parsetree representation is well-chosen.
> Probably a single is_slice flag would have been better.
> * Dumps core on fixed-length arrays, eg
> regression=# select f1[1:] from point_tbl;
> server closed the connection unexpectedly
> I think it should be reverted and sent back for another round of
> review. If not, I'll probably spend tomorrow cleaning it up,
> but I really have other things I should be doing.
> regards, tom lane
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
|Next Message||Robert Haas||2015-12-18 18:32:24||pgsql: pgbench: Change terminology from "threshold" to "parameter".|
|Previous Message||Robert Haas||2015-12-18 17:44:22||pgsql: Remove duplicate word.|