| From: | Antonin Houska <ah(at)cybertec(dot)at> |
|---|---|
| To: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net> |
| Subject: | Re: Adding REPACK [concurrently] |
| Date: | 2026-03-26 08:23:54 |
| Message-ID: | 5667.1774513434@localhost |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> wrote:
> Hello, everyone!
>
> Some comments for v43:
Thanks!
> ------------------------------
>
> src/backend/catalog/index.c:766,1464-1469
>
> "bool progress = (flags & INDEX_CREATE_REPORT_PROGRESS) != 0;"
>
> AFAIU gin, hash and btree (at least) still just unconditionally write
> PROGRESS_CREATEIDX_* progress.
I think you're right, I'll check it.
> src/backend/catalog/toasting.c:334
>
> "INDEX_CREATE_IS_PRIMARY | INDEX_CREATE_REPORT_PROGRESS, 0,"
>
> Should we add the "progress" flag too here and move it from make_new_heap?
Good catch. I'd prefer removing this hunk from the patch because the index on
the TOAST relation is created while it's still empty.
(The other commens have already been addressed by Alvaro.)
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2026-03-26 08:32:41 | Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in functions |
| Previous Message | Lakshmi N | 2026-03-26 08:06:37 | Re: log XLogPrefetch stats at end of recovery |