| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Nikolay Shaplov <n(dot)shaplov(at)postgrespro(dot)ru> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pageinspect patch, for showing tuple data |
| Date: | 2015-11-25 13:06:11 |
| Message-ID: | 5655B243.9000407@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
- bits_len = tuphdr->t_hoff -
- offsetof(HeapTupleHeaderData, t_bits);
+ int bits_len =
+ ((tuphdr->t_infomask2 & HEAP_NATTS_MASK) / 8 + 1) * 8;
As I understand offline comments of Nikolay, current version of page inspect
contains an mistake here. Should we backpatch this?
> OK. I have switched the status of this patch to "Ready for committer"
> (please, committer-san, double-check the area around
> tuple_data_split_internal when fetching data for each attribute, I
> think that we got that right but I may be missing something as well).
Looks good for a first glance
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-11-25 13:13:26 | Re: pageinspect patch, for showing tuple data |
| Previous Message | Grzegorz Sampolski | 2015-11-25 12:45:46 | Re: pam auth - add rhost item |