Re: [PATCH v1] amcheck: Allow interrupting the child-level rightlink walk

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: shihao zhong <zhong950419(at)gmail(dot)com>, 김선동 <mok03127(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH v1] amcheck: Allow interrupting the child-level rightlink walk
Date: 2026-10-05 10:39:50
Message-ID: 565169b4-ff80-44f1-9762-4383314985fa@iki.fi
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 28/08/2026 07:31, shihao zhong wrote:
> On Sat, Jul 18, 2026 at 3:31 AM 김선동 <mok03127(at)gmail(dot)com> wrote:
>>> Resending the v2 patch as an attachment so cfbot can pick it up — the earlier copies went inline. No changes to the patch itself.
>
> Hi Paul,
>
> Thanks for the patch -- I reviewed it and agree with your justification.
> Every other page-traversal loop in verify_nbtree.c already has a
> CHECK_FOR_INTERRUPTS(), and the rightlink walk in bt_child_highkey_check()
> is the only one that was missing it, so this is a nice consistency fix on
> top of the correctness argument you make in the commit message.
>
> The placement is also safe, the function and loop doesn't hold a
> buffer content lock
> across iterations.
>
> LGTM, I think this is good to go.

Committed, thanks.

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias van de Meent 2026-10-05 10:59:32 Re: UNDO with constant time recovery (CTR)
Previous Message Heikki Linnakangas 2026-10-05 10:18:04 Re: [PATCH] Fix vacuum_delay_point happening inside lock