Re: [PATCH v1] amcheck: Allow interrupting the child-level rightlink walk

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: 김선동 <mok03127(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH v1] amcheck: Allow interrupting the child-level rightlink walk
Date: 2026-08-28 04:31:56
Message-ID: CAGRkXqS=ocNby=vrwo4xjnFwTwNLtn_qnqDKCOQPdgx1oR8vrw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 18, 2026 at 3:31 AM 김선동 <mok03127(at)gmail(dot)com> wrote:
>>
>> Resending the v2 patch as an attachment so cfbot can pick it up — the earlier copies went inline. No changes to the patch itself.

Hi Paul,

Thanks for the patch -- I reviewed it and agree with your justification.
Every other page-traversal loop in verify_nbtree.c already has a
CHECK_FOR_INTERRUPTS(), and the rightlink walk in bt_child_highkey_check()
is the only one that was missing it, so this is a nice consistency fix on
top of the correctness argument you make in the commit message.

The placement is also safe, the function and loop doesn't hold a
buffer content lock
across iterations.

LGTM, I think this is good to go.

Thanks,
Shihao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-08-28 04:54:32 Re: Publication of same parent table with ONLY-ness mismatch should error
Previous Message shveta malik 2026-08-28 04:19:01 Re: [PATCH] Release replication slot on error in SQL-callable slot functions