| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | "Syed, Rahila" <Rahila(dot)Syed(at)nttdata(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, "PostgreSQL-development (pgsql-hackers(at)postgresql(dot)org)" <pgsql-hackers(at)postgresql(dot)org>, "Robert Haas (robertmhaas(at)gmail(dot)com)" <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [PROPOSAL] VACUUM Progress Checker. |
| Date: | 2015-11-10 05:44:23 |
| Message-ID: | 56418437.5080003@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015/10/29 23:22, Syed, Rahila wrote:
>
> Please find attached an updated patch.
>
Thanks for the v6. A few quick comments:
- duplicate_oids error in HEAD.
- a compiler warning:
pgstat.c:2898: warning: no previous prototype for ‘pgstat_reset_activityflag’
To fix that use void for empty parameter list -
-extern void pgstat_reset_activityflag();
+extern void pgstat_reset_activityflag(void);
One more change you could do is 's/activityflag/activity_flag/g', which I
guess is a naming related guideline in place.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2015-11-10 06:23:26 | Re: can we add SKIP LOCKED to UPDATE? |
| Previous Message | Tom Lane | 2015-11-10 05:28:54 | Re: bootstrap pg_shseclabel in relcache initialization |