From: | Korry Douglas <korry(dot)douglas(at)enterprisedb(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Patch (2): Implement failover on libpq connect level. |
Date: | 2015-10-23 20:02:33 |
Message-ID: | 562A9259.4060408@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-jdbc |
> On 2015.10.14 at 13:41:51 +0300, Victor Wagner wrote:
>
>> Attached patch which implements client library failover and
>> loadbalancing as was described in the proposal
>> <20150818041850(dot)GA5092(at)wagner(dot)pp(dot)ru>.
>>
> I'm sending imporoved verison of patch. As Olexander Shulgin noted,
> previous version of patch lacks support for service files.
>
> Now support for service files is implemented and multiple host
> statements in the service file are allowed.
A couple of minor nits:
When you call pg_is_in_recovery(), you should schema-qualify the
function name, just in case some other version of that function exists
in the search_path.
Also, pg_is_in_recovery() returns a boolean value - PQgetvalue() will
not return "true" or "false", it will return "t" or "f".
And, you have a bit of garbage in the patch (the patch inserts
UNIXSOCK_PATH(portstr, portnum, conn->pgunixsocket); in the header
comment at the top of fe-connect.c).
-- Korry
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Janes | 2015-10-23 20:56:08 | 9.5Beta1 psql wrapped format expanded output |
Previous Message | Greg Stark | 2015-10-23 19:49:07 | Re: Making tab-complete.c easier to maintain |
From | Date | Subject | |
---|---|---|---|
Next Message | Thom Brown | 2015-10-23 21:14:56 | Re: Patch (2): Implement failover on libpq connect level. |
Previous Message | Victor Wagner | 2015-10-23 11:52:33 | Re: Patch (2): Implement failover on libpq connect level. |