From: | Victor Wagner <vitus(at)wagner(dot)pp(dot)ru> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Patch (2): Implement failover on libpq connect level. |
Date: | 2015-10-24 06:38:12 |
Message-ID: | 20151024093812.6aa47277@wagner.wagner.home |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-jdbc |
В Fri, 23 Oct 2015 16:02:33 -0400
Korry Douglas <korry(dot)douglas(at)enterprisedb(dot)com> пишет:
d> > Now support for service files is implemented and multiple host
> > statements in the service file are allowed.
>
> A couple of minor nits:
>
> When you call pg_is_in_recovery(), you should schema-qualify the
> function name, just in case some other version of that function
> exists in the search_path.
>
> Also, pg_is_in_recovery() returns a boolean value - PQgetvalue() will
> not return "true" or "false", it will return "t" or "f".
>
> And, you have a bit of garbage in the patch (the patch inserts
> UNIXSOCK_PATH(portstr, portnum, conn->pgunixsocket); in the header
> comment at the top of fe-connect.c).
>
Thanks, I'd address this issues in the next version of path.
--
Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>
From | Date | Subject | |
---|---|---|---|
Next Message | Shay Rojansky | 2015-10-24 07:14:54 | Re: Allow ssl_renegotiation_limit in PG 9.5 |
Previous Message | Victor Wagner | 2015-10-24 06:32:41 | Re: Patch (2): Implement failover on libpq connect level. |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Cramer | 2015-10-24 11:15:36 | Re: [HACKERS] JDBC driver debug out? |
Previous Message | Victor Wagner | 2015-10-24 06:32:41 | Re: Patch (2): Implement failover on libpq connect level. |