| From: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Less than ideal error reporting in pg_stat_statements |
| Date: | 2015-09-23 20:43:12 |
| Message-ID: | 56030EE0.4030008@BlueTreble.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/22/15 6:27 PM, Jim Nasby wrote:
>> + ereport(LOG,
>> + (errcode(ERRCODE_OUT_OF_MEMORY),
>> + errmsg("out of memory attempting to pg_stat_statement
>> file"),
>> + errdetail("file \"%s\": size %lld", PGSS_TEXT_FILE,
>> stat.st_size)));
>>
>> Uh, what?
>
> Oops. I'll fix that and address David's concern tomorrow.
New patch attached. I stripped the size reporting out and simplified the
conditionals a bit as well.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
| Attachment | Content-Type | Size |
|---|---|---|
| patch.diff | text/plain | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kam Lasater | 2015-09-23 20:58:26 | Re: No Issue Tracker - Say it Ain't So! |
| Previous Message | Jim Nasby | 2015-09-23 20:41:22 | Re: Less than ideal error reporting in pg_stat_statements |